Skip to content

FAPI: Add ECC encryption/decryption to Fapi_Encrypt/Decrypt#2976

Draft
JuergenReppSIT wants to merge 1 commit intotpm2-software:masterfrom
JuergenReppSIT:fapi-add-ecc-encrypt-decrypt
Draft

FAPI: Add ECC encryption/decryption to Fapi_Encrypt/Decrypt#2976
JuergenReppSIT wants to merge 1 commit intotpm2-software:masterfrom
JuergenReppSIT:fapi-add-ecc-encrypt-decrypt

Conversation

@JuergenReppSIT
Copy link
Copy Markdown
Member

The cipher produced by Fapi_Encrypt contains the marshaled data for the c1, c2, and c3 parameter described in the TPM Spec 1.83. TPM2B_ECC_POINT c1;
TPM2B_MAX_BUFFER c2;
TPM2B_DIGEST c3;

@JuergenReppSIT JuergenReppSIT force-pushed the fapi-add-ecc-encrypt-decrypt branch from e42219b to c078c4a Compare July 23, 2025 16:13
@JuergenReppSIT JuergenReppSIT force-pushed the fapi-add-ecc-encrypt-decrypt branch from c078c4a to 5f682db Compare October 15, 2025 16:02
@AndreasFuchsTPM
Copy link
Copy Markdown
Member

@JuergenReppSIT What would you think about delaying the PR for another release cycle.
The reason is that there is now a TPM spec in public review that support ML-KEM.
Fapi_Encrypt should also support ML-KEM besides ECC and I'd like to spend some more minutes on this.
ok with you ?

@AndreasFuchsTPM AndreasFuchsTPM marked this pull request as draft October 30, 2025 13:51
@JuergenReppSIT
Copy link
Copy Markdown
Member Author

@JuergenReppSIT What would you think about delaying the PR for another release cycle. The reason is that there is now a TPM spec in public review that support ML-KEM. Fapi_Encrypt should also support ML-KEM besides ECC and I'd like to spend some more minutes on this. ok with you ?

@AndreasFuchsTPM yes that would be ok.

@AndreasFuchsTPM AndreasFuchsTPM added this to the 4.3.0 milestone Oct 31, 2025
@JuergenReppSIT JuergenReppSIT force-pushed the fapi-add-ecc-encrypt-decrypt branch from 1ba998e to 2f460a2 Compare December 2, 2025 20:55
@overflowingFrame
Copy link
Copy Markdown
Contributor

Would it also be possible to rebase this PR onto the current main branch? It does cause a lot of non-trivial merge conflicts when I try to do so after commit a1c863e

@JuergenReppSIT
Copy link
Copy Markdown
Member Author

Would it also be possible to rebase this PR onto the current main branch? It does cause a lot of non-trivial merge conflicts when I try to do so after commit a1c863e

I will rebase the PR when PR #3034 is merged.

@JuergenReppSIT JuergenReppSIT force-pushed the fapi-add-ecc-encrypt-decrypt branch from 2f460a2 to fe68bd5 Compare December 4, 2025 10:40
The cipher produced by Fapi_Encrypt contains the marshaled data for
the c1, c2, and c3 parameter described in the TPM Spec 1.83.
TPM2B_ECC_POINT c1;
TPM2B_MAX_BUFFER c2;
TPM2B_DIGEST c3;

Signed-off-by: Juergen Repp <juergen_repp@web.de>
@JuergenReppSIT JuergenReppSIT force-pushed the fapi-add-ecc-encrypt-decrypt branch from fe68bd5 to 8b601a0 Compare December 4, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants