Add build path to use system dependencies with USE_SYSTEM_DEPS#200
Draft
dvrogozh wants to merge 1 commit intouxlfoundation:masterfrom
Draft
Add build path to use system dependencies with USE_SYSTEM_DEPS#200dvrogozh wants to merge 1 commit intouxlfoundation:masterfrom
dvrogozh wants to merge 1 commit intouxlfoundation:masterfrom
Conversation
This does not yet work as some files have dependencies from MPI
unprotected by `ENABLE_MPI`. For example:
* /opt/oneccl/src/atl/util/pm/pmi_resizable_rt/pmi_resizable_simple_internal.cpp
Build fails with:
```
/opt/oneccl/src/atl/util/pm/pmi_resizable_rt/pmi_resizable_simple_internal.cpp:268:25: error: 'ATL_MPI_ROOT_RANK_KEY' was not declared in this scope
268 | if (strcmp(kvs_key, ATL_MPI_ROOT_RANK_KEY) == 0) {
| ^~~~~~~~~~~~~~~~~~~~~
```
For: uxlfoundation#198
Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does not yet work as some files have dependencies from MPI unprotected by
ENABLE_MPI. For example:Build fails with:
For: #198
CC: @frenchwr