set high performance as default power preference for three.js webgl renderer#284
Open
macool wants to merge 1 commit intovideojs:mainfrom
Open
set high performance as default power preference for three.js webgl renderer#284macool wants to merge 1 commit intovideojs:mainfrom
macool wants to merge 1 commit intovideojs:mainfrom
Conversation
…enderer set `high-performance` as the default power preference option for three.js webgl renderer so that browsers enable GPU acceleration
WCPetersen
added a commit
to WCPetersen/videojs-vr
that referenced
this pull request
Feb 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The videojs-vr plugin will instantiate a three.js webgl renderer. This changes the default power preference to be
high-performanceso that devices can take advantage of GPU acceleration.See WebGLContextAttributes: https://registry.khronos.org/webgl/specs/latest/1.0/#5.2
Related: #259
Specific Changes proposed
Change default options for three.js webgl renderer so that it uses power preference: high performance.
Requirements Checklist