fix(template): improves button accessibility and interactivity#22142
Open
li-jia-nan wants to merge 1 commit intovitejs:mainfrom
Open
fix(template): improves button accessibility and interactivity#22142li-jia-nan wants to merge 1 commit intovitejs:mainfrom
li-jia-nan wants to merge 1 commit intovitejs:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the create-vite React and React+TS templates to improve default button behavior and UI affordance in the starter counter button.
Changes:
- Explicitly sets the counter
<button>totype="button"in both React templates. - Adds
cursor: pointer;to the.counterbutton styling in both template CSS files.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/create-vite/template-react/src/App.jsx | Adds type="button" to the counter button to avoid unintended submit behavior. |
| packages/create-vite/template-react/src/App.css | Adds cursor: pointer to improve perceived interactivity of the counter button. |
| packages/create-vite/template-react-ts/src/App.tsx | Adds type="button" to the counter button to avoid unintended submit behavior. |
| packages/create-vite/template-react-ts/src/App.css | Adds cursor: pointer to improve perceived interactivity of the counter button. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.