Switch topological sort to SCC in condition extraction.#207
Merged
garretrieger merged 1 commit intow3c:mainfrom Apr 10, 2026
Merged
Switch topological sort to SCC in condition extraction.#207garretrieger merged 1 commit intow3c:mainfrom
garretrieger merged 1 commit intow3c:mainfrom
Conversation
Dependency graphs can have cycles within a closure phase (for example bidi mirror dependencies naturally form cycles). Since topological sorting can't handle cycles a different approach is needed. In condition extraction topological sorting is swapped out with a strongly connected component finding algorithm (Tarjan's, ref: https://en.wikipedia.org/wiki/Tarjan%27s_strongly_connected_components_algorithm). This returns a topological sorting of strongly connected components. When the dependency graph is a DAG this gives the exact same behaviour as the prior topological sorting based implementation. To handle the cycles within a strongly connected component condition propagation has been modified to iteratively propagate conditions inside a component until they stabilize.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency graphs can have cycles within a closure phase (for example bidi mirror dependencies naturally form cycles). Since topological sorting can't handle cycles a different approach is needed.
In condition extraction topological sorting is swapped out with a strongly connected component finding algorithm (Tarjan's, ref: https://en.wikipedia.org/wiki/Tarjan%27s_strongly_connected_components_algorithm). This returns a topological sorting of strongly connected components. When the dependency graph is a DAG this gives the exact same behaviour as the prior topological sorting based implementation. To handle the cycles within a strongly connected component condition propagation has been modified to iteratively propagate conditions inside a component until they stabilize.
New high level algorithm: