Rework DependencyClosure to utilize exact node conditions.#210
Merged
garretrieger merged 7 commits intow3c:mainfrom Apr 15, 2026
Merged
Rework DependencyClosure to utilize exact node conditions.#210garretrieger merged 7 commits intow3c:mainfrom
garretrieger merged 7 commits intow3c:mainfrom
Conversation
Cached values are invalidated and updated as needed.
…ee_set<Node>>. This significantly reduces overhead associated with creating multiple nested btree_set's.
…ions. This significantly simplifies the implementation and allows it to work in cases we'd previously reject. Also remove a code and reachability indices that are no longer needed.
Will be needed to re-implement SegmentsThatInteractWith(...)
Additionally drops a bunch of now uneeded code from DependencyClosure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces implementations of AnalyzeSegment() and SegmentsThatInteractWith() to utilize exact per node conditions extracted from the dependency graph. This significantly simplifies both implementations and allows a significant amount of code to be dropped from DependencyClosure.
DependencyClosure::AnalyzeSegment() now works in more cases, and is significantly sped up vs the prior implementation.