-
Notifications
You must be signed in to change notification settings - Fork 396
fix(ci): run build and test in the same step to avoid recompilation #2230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MarcosNicolau
merged 5 commits into
staging
from
2229-fixci-run-build-and-test-in-the-same-step-to-avoid-recompilation
Jan 8, 2026
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8dec02a
fix(ci): run build and test in the same step to avoid recompilation
JuArce 09ae9ec
fix warnings
JuArce fbdc2f7
Merge branch 'refs/heads/staging' into 2229-fixci-run-build-and-test-…
JuArce 6a9abab
fmt
JuArce 7a93ff9
Apply suggestion from @maximopalopoli
JuArce File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
aggregation_mode/proof_aggregator/src/bin/proof_aggregator_cpu.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| #[tokio::main] | ||
| async fn main() { | ||
| proof_aggregator::run().await; | ||
| } |
4 changes: 4 additions & 0 deletions
4
aggregation_mode/proof_aggregator/src/bin/proof_aggregator_dev.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| #[tokio::main] | ||
| async fn main() { | ||
| proof_aggregator::run().await; | ||
| } |
4 changes: 4 additions & 0 deletions
4
aggregation_mode/proof_aggregator/src/bin/proof_aggregator_gpu.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| #[tokio::main] | ||
| async fn main() { | ||
| proof_aggregator::run().await; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,34 @@ | ||
| pub mod aggregators; | ||
| pub mod backend; | ||
|
|
||
| use backend::{config::Config, ProofAggregator}; | ||
| use std::env; | ||
| use tracing_subscriber::{EnvFilter, FmtSubscriber}; | ||
|
|
||
| fn read_config_filepath_from_args() -> String { | ||
| let args: Vec<String> = env::args().collect(); | ||
| if args.len() < 2 { | ||
| panic!( | ||
| "You mus provide a config file. Usage: {} <config-file-path>", | ||
| args[0] | ||
| ); | ||
| } | ||
|
|
||
| args[1].clone() | ||
| } | ||
|
|
||
| pub async fn run() { | ||
| // ignore sp1_cuda info logs | ||
| let filter = EnvFilter::new("info,sp1_cuda=warn"); | ||
| let subscriber = FmtSubscriber::builder().with_env_filter(filter).finish(); | ||
| tracing::subscriber::set_global_default(subscriber).expect("setting default subscriber failed"); | ||
|
|
||
| // load config | ||
| let config_file_path = read_config_filepath_from_args(); | ||
| tracing::info!("Loading config from {}...", config_file_path); | ||
| let config = Config::from_file(&config_file_path).expect("Config is valid"); | ||
| tracing::info!("Config loaded"); | ||
|
|
||
| let mut proof_aggregator = ProofAggregator::new(config).await; | ||
| proof_aggregator.start().await; | ||
| } | ||
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.