chore(shortint): use TEST_ params as much as possible in tests#3477
Open
nsarlin-zama wants to merge 2 commits intomainfrom
Open
chore(shortint): use TEST_ params as much as possible in tests#3477nsarlin-zama wants to merge 2 commits intomainfrom
nsarlin-zama wants to merge 2 commits intomainfrom
Conversation
7537710 to
5e64f7c
Compare
c02460e to
447a247
Compare
Contributor
Author
|
changed some TEST_ params to point to the corresponding default param defined in |
447a247 to
e15da5c
Compare
That way we are sure that prod params are always tested
e15da5c to
ea3b1a7
Compare
IceTDrinker
approved these changes
Apr 23, 2026
Member
IceTDrinker
left a comment
There was a problem hiding this comment.
Thanks !
@IceTDrinker reviewed 7 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on mayeul-zama).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: please link all relevant issues
PR content/description
shortint use a mix of test and default params.
I asked Claude to do a review of the params used in shortint
_ci_run_filtertests before the pr:This pr standardises this and try to use TEST_ params as much as possible.
Should be merged after #3474
This change is