Skip to content

chore(shortint): use TEST_ params as much as possible in tests#3477

Open
nsarlin-zama wants to merge 2 commits intomainfrom
ns/chore/use_test_params
Open

chore(shortint): use TEST_ params as much as possible in tests#3477
nsarlin-zama wants to merge 2 commits intomainfrom
ns/chore/use_test_params

Conversation

@nsarlin-zama
Copy link
Copy Markdown
Contributor

@nsarlin-zama nsarlin-zama commented Apr 16, 2026

closes: please link all relevant issues

PR content/description

shortint use a mix of test and default params.

I asked Claude to do a review of the params used in shortint _ci_run_filter tests before the pr:

  ┌──────────────────────┬───────┐
  │       Category       │ Count │
  ├──────────────────────┼───────┤
  │ No params            │ 9     │
  ├──────────────────────┼───────┤
  │ TEST_ only           │ 17    │
  ├──────────────────────┼───────┤
  │ PARAM_ only          │ 10    │
  ├──────────────────────┼───────┤
  │ Mixed TEST_ + PARAM_ │ 3     │
  ├──────────────────────┼───────┤
  │ Total                │ 39    │
  └──────────────────────┴───────┘

This pr standardises this and try to use TEST_ params as much as possible.

Should be merged after #3474


This change is Reviewable

@cla-bot cla-bot Bot added the cla-signed label Apr 16, 2026
@nsarlin-zama nsarlin-zama force-pushed the ns/chore/use_test_params branch 2 times, most recently from 7537710 to 5e64f7c Compare April 16, 2026 08:50
@nsarlin-zama nsarlin-zama changed the title fix(chore): use TEST_ params as much as possible in tests chore(shortint): use TEST_ params as much as possible in tests Apr 16, 2026
Base automatically changed from ns/fix/compact_list_without_fn to main April 20, 2026 12:15
@nsarlin-zama nsarlin-zama force-pushed the ns/chore/use_test_params branch 2 times, most recently from c02460e to 447a247 Compare April 20, 2026 15:25
@nsarlin-zama
Copy link
Copy Markdown
Contributor Author

changed some TEST_ params to point to the corresponding default param defined in aliases.rs. That way we make sure that default params are always tested

@nsarlin-zama nsarlin-zama force-pushed the ns/chore/use_test_params branch from 447a247 to e15da5c Compare April 20, 2026 15:38
@nsarlin-zama nsarlin-zama force-pushed the ns/chore/use_test_params branch from e15da5c to ea3b1a7 Compare April 20, 2026 16:04
Copy link
Copy Markdown
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@IceTDrinker reviewed 7 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on mayeul-zama).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants