Conversation
No need to have a specific Error enum while there is io::Error.
Use io::* provided enums instead.
Avoid passing send_sessions too deep. Get rid of IrrecoverableError.
Avoid re-creating a buffer, unify naming.
It doesn't really do much.
Keep code as close to the left as possible.
Move it to a specific module and make it a Enum to simplify usage.
It is excessive to return a vector from it.
In general, static dispatch is preferrable over the dynamic one. In this case, it insignificantly increases the binary size and slightly decreases memory footprint.
Emphasize that a structure is consumed.
Apt cache may be outdated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.