Conversation
The project depends on libguestfs and inotify. Both are absent in Windows environment. See: https://libguestfs.org/ See: https://man7.org/linux/man-pages/man7/inotify.7.html
Inotify usage was added earlier. See: 36d7c35
guestfs_stat is always used as a non-owned raw pointer.
A brodercase with timeout == 0 is not covered. Max timeout value is capped to 255 not 60. See: https://www.rfc-editor.org/rfc/rfc2349.html
According to RFC, it is bottomed to 8 bytes. See: https://www.rfc-editor.org/rfc/rfc2348.html
Add ability to serve common files for all peers from the directory named "default" inside tftp_root directory.
Encapsulate option negotiation logic inside a specific function. Send timeout error after negotiation failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.