chore: make eval scripts cross-platform compatible (Windows)#1030
Merged
OrKoN merged 1 commit intoChromeDevTools:mainfrom Feb 24, 2026
Merged
chore: make eval scripts cross-platform compatible (Windows)#1030OrKoN merged 1 commit intoChromeDevTools:mainfrom
OrKoN merged 1 commit intoChromeDevTools:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Use `pathToFileURL` for dynamic imports in eval_gemini.ts to fix `ERR_UNSUPPORTED_ESM_URL_SCHEME` on Windows. Move env var from shell syntax into script code for cross-platform compatibility. Add .gitattributes to enforce LF line endings.
passtas
force-pushed
the
fix/eval-windows-compat
branch
from
2a5d156 to
a2f3850
Compare
OrKoN
changed the title
wolfib
pushed a commit
to wolfib/chrome-devtools-mcp
that referenced
this pull request
Mar 10, 2026
…evTools#1030) Fixes ChromeDevTools#1029 ## Summary - Use `pathToFileURL()` from `node:url` for dynamic imports in `eval_gemini.ts` to fix `ERR_UNSUPPORTED_ESM_URL_SCHEME` on Windows - converts absolute paths like `D:\projects\...\console_test.ts` to proper `file:///D:/projects/.../console_test.ts` URLs that the Node.js ESM loader accepts on all platforms - Move `CHROME_DEVTOOLS_MCP_NO_USAGE_STATISTICS=true` from Unix-only shell env var prefix in `package.json` into `eval_gemini.ts` code, matching the pattern already used in `scripts/test.mjs` - Add `.gitattributes` with `* text=auto eol=lf` to enforce LF line endings on checkout - Windows contributors cloning the repo would otherwise get CRLF endings, which conflicts with the project's Prettier `endOfLine: 'lf'` config and causes spurious diffs or formatting failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1029
Summary
pathToFileURL()fromnode:urlfor dynamic imports ineval_gemini.tsto fixERR_UNSUPPORTED_ESM_URL_SCHEMEon Windows - converts absolute paths likeD:\projects\...\console_test.tsto properfile:///D:/projects/.../console_test.tsURLs that the Node.js ESM loader accepts on all platformsCHROME_DEVTOOLS_MCP_NO_USAGE_STATISTICS=truefrom Unix-only shell env var prefix inpackage.jsonintoeval_gemini.tscode, matching the pattern already used inscripts/test.mjs.gitattributeswith* text=auto eol=lfto enforce LF line endings on checkout - Windows contributors cloning the repo would otherwise get CRLF endings, which conflicts with the project's PrettierendOfLine: 'lf'config and causes spurious diffs or formatting failures