Merge pull request #8674 from gadfort/gui-gif-safe

gui: guard against empty gif generation

Author: maliberty

src/gui/src/gui.cpp

@@ -1450,6 +1450,10 @@ void Gui::gifStart(const std::string& filename)
     logger_->error(utl::GUI, 49, "Cannot generate GIF without GUI enabled");
   }
 
+  if (filename.empty()) {
+    logger_->error(utl::GUI, 81, "Filename is required to save a GIF.");
+  }
+
   gif_ = std::make_unique<GIF>();
   gif_->filename = filename;
   gif_->writer = nullptr;
@@ -1546,6 +1550,15 @@ void Gui::gifEnd()
     return;
   }
 
+  if (gif_->writer == nullptr) {
+    logger_->warn(utl::GUI,
+                  75,
+                  "Nothing to save to {}. No frames added to gif.",
+                  gif_->filename);
+    gif_ = nullptr;
+    return;
+  }
+
   GifEnd(gif_->writer.get());
   gif_ = nullptr;
 }