OpenAPI: Show custom endpoints, fix content negotiation#1747
Merged
OpenAPI: Show custom endpoints, fix content negotiation#1747
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1747 +/- ##
==========================================
+ Coverage 90.75% 90.78% +0.02%
==========================================
Files 468 474 +6
Lines 14662 14697 +35
Branches 2315 2319 +4
==========================================
+ Hits 13306 13342 +36
- Misses 920 921 +1
+ Partials 436 434 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…warning for non-standard JSON:API action methods; fix broken content negotiation.
eabf07f to
07b69d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for non-JSON:API endpoints (both Controllers and Minimal API endpoints), which now show up in SwaggerUI and generated clients. Custom action methods in JSON:API controllers are still hidden; a warning is logged now. It's currently unclear how that's supposed to work; please let us know what you expect from that by opening a new issue.
For JSON:API endpoints, the code that adds produces/consumes metadata was refactored, so it no longer influences ASP.NET routing. This fixes the bug where adding
services.AddOpenApiForJsonApi()to your project changed the required media type for all requests.Closes #1729.
QUALITY CHECKLIST